Do not execute "regress" CI on PR #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce the CI execution time on servers
|
@cathales Can you approve ? |
|
✔️ successful run, report available here. |
cathales
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
LGTM, I’m looking forward to two changes so that switching PR CI from regress to dev actually reduces latency for contributors:
- an FPGA build optimization (eg: caching Vivado primitives)
- triggering the Thales CI from a GitHub webhook on PR&master pushes instead of on schedule
|
Agree on the two improvement proposals |
Update: this should be working from now 🚀 @JeanRochCoulon should we create a task to investigate possible FPGA build duration optimizations? |
|
Yes and you can assign our specialist: Guillaume |
|
It seems I’m not allowed to add tasks |
|
Give me the texte you would like to add in kanban board, I will do the job |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the CI execution time on servers